feat: support arbitrarily long PACKSQUASH_SYSTEM_IDs
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ComunidadAylas/PackSquash@bf7188d made PackSquash support arbitrarily long system ID hex strings. In addition to being somewhat safer and more scalable, such a simple format also simplifies the action a bit by doing away with the need for an external dependency for generating UUIDs. However, this new format is not backwards compatible, so care should be taken to avoid using it with older PackSquash versions. To achieve that outcome, let's leverage the version manifest system we already have to introduce such a breaking behavior bump while handling older versions of both PackSquash and the action as gracefully as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background, motivation, purpose, and description
ComunidadAylas/PackSquash@bf7188d made PackSquash support arbitrarily long system ID hex strings. In addition to being somewhat safer and more scalable, such a simple format also simplifies the action a bit by doing away with the need for an external dependency for generating UUIDs. However, this new format is not backwards compatible, so care should be taken to avoid using it with older PackSquash versions. To achieve that outcome, let's leverage the version manifest system we already have to introduce such a breaking behavior bump while handling older versions of both PackSquash and the action as gracefully as possible.
For now, this PR is kept as a draft because such changes didn't make it to any stable PackSquash release, so the action with the new version manifest format wouldn't work in its most common configuration of using the latest stable version. Moreover, the CDN routes for such manifest files weren't set up either.
Usage
No significant updates to end-user workflows are expected, since in the vast majority of cases system ID handling is transparent for them. Users that have manually set a system ID can continue using the older UUID format for the time being.