Skip to content

Conversation

@fortuna
Copy link
Collaborator

@fortuna fortuna commented Jun 7, 2019

This moves application logic out of the ui components.
Also, stops using the hidden approach and uses a dialog instead, which is a more maintainable pattern.

@fortuna fortuna requested a review from alalamav June 7, 2019 17:20
@alalamav
Copy link
Contributor

alalamav commented Jun 7, 2019

I think the dialog would look better with some more spacing between the image and the text.
Also, the unit tests are failing, presumably due to the refactor?

@fortuna
Copy link
Collaborator Author

fortuna commented Jun 7, 2019

Ugh, I found out what the problem is: the tests don't define localStorage. I'll need to figure out what to do after I'm back from RightsCon.

@JonathanDCohen
Copy link
Contributor

@fortuna do you still want to do this?

@fortuna fortuna marked this pull request as draft June 8, 2020 17:28
@fortuna fortuna removed the request for review from alalamav August 19, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants