-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Blocks: Always trigger borwser console warnings for blocks with apiVersion below 2 #73815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Size Change: +21 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
|
I agree with the proposed changes. Using the deprecation makes more sense, since we're trying to deprecate old |
|
Flaky tests detected in a0cc46e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20027659152
|
|
Thanks for the review, both! I've updated the Jest mocks to suppress the deprecation warnings, and will merge this PR once all CI passes. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Some of unit tests are failing, probably due to this global jest mock. I'll investigate further. |
What?
This PR makes the browser console warnings for blocks with apiVersion below 2 more prominent by using
deprecatedinstead ofwarning. This means that a console message is always triggered regardless of the SCRIPT_DEBUG setting.Why?
To further encourage consumers to test blocks for the future iframe post editor.
How?
Note that the documentation link has been replaced with new documentation added in #73778.
Testing Instructions
Run the following code via your browser console and check the displayed message.
Screenshots or screencast