[core] Fix incremental query unable to read changelog when batchScanSkipLevel0 is enabled #6699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eletion vectors are enabled and changelog producer is set to 'input'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #6698
If the table is dv enabled or using first-row as merge engine, DataTableBatchScan filters out records with level = 0. This breaks incremental queries using the input changelog producer, as changelog entries are incorrectly excluded. This change ensures changelog records are preserved in such scenarios.
Tests
IncrementalTableTest#testIncrementalWithInputChangeLogAndMoW: Added in the PR.
API and Format
No API changes.
No storage format changes.
Documentation
None