Turn on -Werror flag for unit tests

[maddeleine]

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

We have -Werror turned on by default for our build of the s2n-tls library, but it is not turned on when we build our unit tests. This is bad hygiene and it seems we've developed multiple compiler warnings in our unit tests because of it.

Need By Date:

N/A

Solution:

Add the -Werror flag to our Cmake file where we build the unit tests. Also fix all the compiler warnings that show up. Maybe use UNSAFE_TREAT_WARNINGS_AS_ERRORS flag since we have it.

Requirements / Acceptance Criteria:

-Werror is added to our unit test build.

Out of scope:

Is there anything the solution will intentionally NOT address?

[thulasiramk-2310]

Hi @maddeleine ! I’d like to work on this issue.

My proposed approach:

1.Identify the relevant CMakeLists.txt files where unit tests are built.
2.Enable the -Werror flag using the UNSAFE_TREAT_WARNINGS_AS_ERRORS mechanism as suggested.
3.Build the unit tests locally to surface all existing compiler warnings.
4.Resolve the warnings systematically while ensuring all tests continue to pass.
5.Open a PR with the CMake update and the warning fixes.

May I be assigned to the issue?

Thanks!

[maddeleine]

Hi @thulasiramk-2310, if you want to try to fix it, go ahead! I'm not sure how easy it will be to fix the unit test compiler warnings, but feel free to make an attempt.

[thulasiramk-2310]

Thanks @maddeleine!
I’ll get started and share updates as I make progress. If I run into anything unclear regarding the warning fixes, I’ll reach out. Thanks for the guidance!