Run URL conventions Danger only on added lines #11570
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11478. I noticed in #11536 that the warnings are emitted even if deleting an existing badge that does not follow URL conventions. This PR adds a
^\+[...]mbit to the regex to only look for added lines, i.e. ones starting with+. I also combined the two regexes into one.I've tested this with the following command which no longer produces the false positive:
Other cases still trigger as expected: