Skip to content

When changing format of a new partition, don't require wipe #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ogayot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

When changing format of a new partition, don't require wipe #2148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b2719
storage: add note about format=None vs format=""
ogayot Jan 27, 2025
60693ec
storage: when changing format of a new partition, don't require wipe
ogayot Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions subiquity/server/controllers/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,10 +1398,16 @@ async def v2_edit_partition_POST(
if data.partition.boot is not None and data.partition.boot != partition.boot:
raise ValueError("edit_partition does not support changing boot")
spec: PartitionSpec = {"mount": data.partition.mount or partition.mount}
# NOTE from ogayot: it is my understanding that in this context, having
# format=None (which is the default value) means to keep the current
# format. To change from ext4 to "unformatted", one must specify
# format="".
if data.partition.format is not None:
if data.partition.format != partition.original_fstype():
if data.partition.wipe is None:
raise ValueError("changing partition format requires a wipe value")
if data.partition.wipe is None and partition.preserve:
Copy link
Member Author

@ogayot ogayot Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check the value of preserve at the FS level (which may or may not exist) ? This is what we do to label "to be reformatted as ...." and "to be formatted as ....".

subiquity/subiquity/common/filesystem/labels.py

Lines 228 to 235 in ad2dd0a

fs = device.fs()
if fs is not None:
if fs.preserve:
format_desc = _("already formatted as {fstype}")
elif device.original_fstype() is not None:
format_desc = _("to be reformatted as {fstype}")
else:
format_desc = _("to be formatted as {fstype}")

Copy link
Member Author

@ogayot ogayot Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbungert do you know? i.e., the difference between partition.preserve and partition.fs.preserve?

Copy link
Member

@dbungert dbungert Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will defer to the curtin documentation on this one. https://curtin.readthedocs.io/en/latest/topics/storage.html

From a label standpoint this is a very subtle difference.

Copy link
Contributor

@Chris-Peterson444 Chris-Peterson444 May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, this works because preserve is already set for existing objects by default?

raise ValueError(
"changing format of existing partition requires a wipe value"
)
spec["fstype"] = data.partition.format
if data.partition.size is not None:
spec["size"] = data.partition.size
Expand Down
Loading