identity: avoid using the password argument when creating a user #2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Peterson444
approved these changes
Nov 25, 2025
Contributor
Chris-Peterson444
left a comment
Chris-Peterson444
left a comment
There was a problem hiding this comment.
Nice, LGTM. Tentative yes based on the VM tests showing no logged passwords on the chpasswd call.
Thanks!
We can now pass input when calling runner.run() using the "input" argument. That said, because of how reading stdin is implemented in systemd-run, using input="something" will cause stdout and stderr to not end up in the journal. Therefore, we currently only allow input="something" in combination with capture=True. In the future, it would be good to support one without the other. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
ogayot
force-pushed
the
chpasswd
branch
2 times, most recently
from
15859b0 to
62e9a9b
Compare
Member
Author
|
Well, the original implementation was far from a working implementation. The following problems were found during testing and have been resolved:
|
ogayot
commented
Nov 27, 2025
Comment on lines
-81
to
-83
| source: https://git.launchpad.net/curtin | ||
| source: https://git.launchpad.net/~ogayot/curtin | ||
| source-type: git | ||
| source-commit: "ff79541249aa40f228f87681cdb028c69975cd8c" |
Member
Author
There was a problem hiding this comment.
To update once the MP has been merged.
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
In general, if we pass an encrypted password using the --password option of useradd, then we need to make sure that the invocation is not logged anywhere. This is challenging to do, especially in Subiquity where we run useradd through systemd-run. Indeed the command automatically gets recorded in the journal as a transient unit. To avoid the problem, we now call useradd without the password option, and then immediately call chpasswd to update the password, using stdin. Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
dbungert
approved these changes
Dec 1, 2025
| ",".join(sorted(groups)), | ||
| "--create-home", | ||
| ] | ||
| async def run_in_target(cmd: list[str], **kwargs): |
Member
There was a problem hiding this comment.
(future PR) we have 13 places where we run "in-target", moving a helper like this to subiquity/server/curtin.py would help.
Chris-Peterson444
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, if we pass an encrypted password using the --password option of useradd, then we need to make sure that the invocation is not logged anywhere.
This is challenging to do. Furthermore, in Subiquity, we run useradd through systemd-run, so the command automatically gets recorded in the journal as a transient unit.
To avoid the problem, we now call useradd without the password option, and then immediately call chpasswd to update the password, using stdin.
Marking as a draft until I test in a VM.Depends on https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/496404