SBSECP256K1ValidateKey builtin
#22415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpulley-da
changed the title
SBSECP256K1ValidateKeyBool builtinSBSECP256K1ValidateKey builtin
carlpulley-da
commented
Nov 26, 2025
| } | ||
| } | ||
|
|
||
| object SBSECP256K1BoolTest { |
Contributor
Author
There was a problem hiding this comment.
Moved to DERTestLib
carlpulley-da
commented
Nov 26, 2025
|
|
||
| import java.math.BigInteger | ||
|
|
||
| object DERTestLib { |
Contributor
Author
There was a problem hiding this comment.
Copied from the object SBSECP256K1BoolTest - now shared across 2 crypto primitive builtin tests (as part of the interpreter-test-lib)
remyhaemmerle-da
approved these changes
Dec 1, 2025
Comment on lines
+834
to
+837
| case _: NoSuchProviderException => | ||
| crash("JCE Provider BouncyCastle not found") | ||
| case _: NoSuchAlgorithmException => | ||
| crash("BouncyCastle provider fails to support SECP256K1") |
Collaborator
There was a problem hiding this comment.
I would move the unexpected error last
| // Copyright (c) 2025 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package com.digitalasset.daml.lf |
Collaborator
There was a problem hiding this comment.
maybe we could factorize with other test for crypto primitives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBSECP256K1ValidateKeybuiltinSBSECP256K1ValidateKeybuiltin