Attachment improvements - Pasted text attachments #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
pasted-attachments
branch
from
3de392a to
c3329b3
Compare
Contributor
Author
|
moving to draft because i have to reconcile these changes with the changes made in #1012 that i was unaware of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a simple banner on top of the text area to show what files have been attached to the message.
If a user clicks on an attachment in the banner, they can see a preview of the file.
If the user pastes more than 10 lines or 500 chars, create a temp file and attach it instead
This pasted content will then behave the same as normal attachments
Since this is already more than big enough, a subsequent PR will bring more improvements like showing attachments on the messages too
Screenshots: