[DRAFT] Use global.json to restrict .NET SDK use #3797

paulmedynski · 2025-11-21T15:22:35Z

Description

Added global.json to restrict our SDK to the single supported version, currently 10.0.
Using global.json to install .NET SDKs everywhere except when we may need ARM64.
Removed unnecessary installation of .NET runtimes where they aren't needed.

Testing

PR, CI, and Official pipelines will validate.

Copilot

Pull request overview

This PR introduces global.json to standardize the .NET SDK version (9.0.0) across the project and migrates pipeline files to use UseDotNet@2 with useGlobalJson: true instead of hardcoded version numbers or the ensure-dotnet-version.yml template. The changes simplify SDK installation, remove unnecessary runtime installations in build-only scenarios, and reduce redundant .NET Framework test targets in the stress tests.

Key changes:

Added global.json specifying .NET 9.0 SDK with rollForward: "feature" policy
Updated 6 pipeline files to use UseDotNet@2 with useGlobalJson: true
Removed installation of .NET 8.x runtime in build-only scenarios where tests aren't run
Reduced stress test .NET Framework targets from 6 versions to just net462

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
global.json	New file specifying .NET 9.0.0 SDK requirement with feature rollforward and no prerelease versions
eng/pipelines/steps/compound-build-akv-step.yml	Migrated from hardcoded SDK/runtime installation to global.json; removed unnecessary .NET 8.x runtime
eng/pipelines/stages/stress-tests-ci-stage.yml	Reduced .NET Framework test targets from 6 versions to just net462
eng/pipelines/jobs/stress-tests-ci-job.yml	Updated to use global.json for SDK installation and changed .NET 8 runtime from '8.x' to '8.0'
eng/pipelines/dotnet-sqlclient-ci-core.yml	Added net9.0 to x86 test target frameworks with explanatory comments
eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml	Migrated to global.json; removed unnecessary .NET 8.x runtime installation
eng/pipelines/common/templates/jobs/ci-run-tests-job.yml	Simplified x86 SDK/runtime installation using global.json and added .NET 8.0 runtime for tests
eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml	Replaced ensure-dotnet-version template with UseDotNet@2 using global.json

global.json

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

eng/pipelines/jobs/stress-tests-ci-job.yml

paulmedynski

Commentary for reviewers.

paulmedynski · 2025-11-21T15:23:27Z

eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml

-        parameters:
-            packageType: 'sdk'
-            version: '10.0'
+      # Install whichever .NET SDKs are specified in our global.json.


Code coverage only runs on Windows x64, so we don't need the special ensure-dotnet.version template here.

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

paulmedynski · 2025-11-21T15:26:28Z

eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml

-    packageType: sdk
-    version: '9.x'
-
- task: UseDotNet@2


We don't need a .NET 8 runtime to build things. We would only need it to run tests, which doesn't happen as part of this pipeline tree.

paulmedynski · 2025-11-21T15:27:20Z

eng/pipelines/steps/compound-build-akv-step.yml

-          packageType: 'sdk'
-          version: '9.x'
-
-    - task: UseDotNet@2


We don't need a .NET 8 runtime to build things. We would only need it to run tests, which doesn't happen as part of this pipeline tree.

global.json

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

eng/pipelines/jobs/stress-tests-ci-job.yml:146

With the stress tests now targeting net9.0 (as specified in netTestRuntimes parameter which defaults to [net8.0, net9.0]), the .NET 9.0 runtime should also be installed. Consider adding:

# Install the .NET 9.0 runtime to run tests that target it.
- task: UseDotNet@2
  displayName: Install .NET 9.0 Runtime
  inputs:
    packageType: runtime
    version: 9.x

  # Install the .NET 8.0 runtime to run tests that target it.
  - task: UseDotNet@2
    displayName: Install .NET 8.0 Runtime
    inputs:
      packageType: runtime
      version: 8.x

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

eng/pipelines/stages/stress-tests-ci-stage.yml

eng/pipelines/common/templates/steps/ci-project-build-step.yml

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 16 comments.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

eng/pipelines/common/templates/steps/ensure-dotnet-version.yml

global.json

eng/pipelines/common/templates/steps/ensure-dotnet-version.yml

eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml

eng/pipelines/common/templates/steps/ci-prebuild-step.yml

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

eng/pipelines/common/templates/steps/ensure-dotnet-version.yml

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

eng/pipelines/common/templates/steps/ensure-dotnet-version.yml

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

README.md

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

eng/pipelines/steps/install-dotnet-arm64.yml

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

eng/pipelines/jobs/stress-tests-ci-job.yml:145

The stress test job installs the .NET 8.0 runtime but not the .NET 9.0 runtime. Since the stress tests target net9.0 (as seen in stress-tests-ci-stage.yml line 57 which defaults to [net8.0, net9.0]), the .NET 9.0 runtime should also be installed.

Add a step after line 144 to install the .NET 9.0 runtime:

- task: UseDotNet@2
  displayName: Install .NET 9.0 Runtime
  inputs:
    packageType: runtime
    version: 9.x

  - task: UseDotNet@2
    displayName: Install .NET 8.0 Runtime
    inputs:
      packageType: runtime

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

eng/pipelines/common/templates/steps/pre-build-step.yml

eng/pipelines/steps/install-dotnet-arm64.yml

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

…on, currently 9.0. - Using global.json to install .NET SDKs everywhere except when we may need ARM64. - Removed unnecessary installation of .NET SDKs and runtimes where they aren't needed. - Added all target frameworks to the x86 test runs. - Updated documentation related to SDKs. - Removed runtime ARM64 architecture detection in favour of explicit parameters for the test jobs that use ARM64. - Suppressing CredScan errors related to test secrets.

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

BUILDGUIDE.md

eng/pipelines/steps/install-dotnet-arm64.yml

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

eng/pipelines/stages/stress-tests-ci-stage.yml

- Updated install-dotnet template to handle all cases of .NET SDK and Runtime installation for the pipelines.

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

Copilot · 2025-12-05T20:43:43Z

src/Microsoft.Data.SqlClient.sln

 		..\eng\pipelines\steps\compound-publish-symbols-step.yml = ..\eng\pipelines\steps\compound-publish-symbols-step.yml
 		..\eng\pipelines\steps\roslyn-analyzers-akv-step.yml = ..\eng\pipelines\steps\roslyn-analyzers-akv-step.yml
 		..\eng\pipelines\steps\script-output-environment-variables-step.yml = ..\eng\pipelines\steps\script-output-environment-variables-step.yml
+		..\eng\pipelines\steps\install-dotnet-arm64.yml = ..\eng\pipelines\steps\install-dotnet-arm64.yml


The file reference is to install-dotnet-arm64.yml, but the actual file created in this PR is install-dotnet-arm64.ps1 (a PowerShell script, not a YAML file). This appears to be incorrect. Either the solution file should reference install-dotnet-arm64.ps1, or if you intended to reference the YAML template, it should be install-dotnet.yml.

Suggested change

..\eng\pipelines\steps\install-dotnet-arm64.yml = ..\eng\pipelines\steps\install-dotnet-arm64.yml

..\eng\pipelines\steps\install-dotnet-arm64.ps1 = ..\eng\pipelines\steps\install-dotnet-arm64.ps1

Copilot · 2025-12-05T20:43:44Z

eng/pipelines/steps/install-dotnet.yml

+    - task: PowerShell@2
+      displayName: Install .NET SDK and Runtimes for ARM64
+      pwsh: true
+      filePath: install-dotnet-arm64.ps1


The filePath parameter for PowerShell@2 task should include a full or relative path. The current value install-dotnet-arm64.ps1 assumes the script is in the working directory. Consider using a path relative to the repo root like $(Build.SourcesDirectory)/eng/pipelines/steps/install-dotnet-arm64.ps1 or ./eng/pipelines/steps/install-dotnet-arm64.ps1 to ensure the script can be found reliably.

Suggested change

filePath: install-dotnet-arm64.ps1

filePath: $(Build.SourcesDirectory)/eng/pipelines/steps/install-dotnet-arm64.ps1

Copilot · 2025-12-05T20:43:44Z

eng/pipelines/steps/install-dotnet-arm64.ps1

+  Write-Host ($installParams | ConvertTo-Json -Depth 1)
+}
+
+& ./dotnet-install.ps1 -Verbose:$Debug -DryRun:$DryRun @installParams


The script invokes ./dotnet-install.ps1 with a relative path, which assumes the current working directory contains the script. However, based on line 70-77, the script is downloaded to $InstallDir/dotnet-install.ps1. The invocation should use & "$InstallDir/dotnet-install.ps1" instead to ensure the correct script is executed.

Copilot · 2025-12-05T20:43:45Z

eng/pipelines/steps/install-dotnet-arm64.ps1

+    Write-Host ($installParams | ConvertTo-Json -Depth 1)
+  }
+
+  & ./dotnet-install.ps1 -Verbose:$Debug -DryRun:$DryRun @installParams


Same issue as line 118: the script invokes ./dotnet-install.ps1 with a relative path. This should be & "$InstallDir/dotnet-install.ps1" to ensure the correct script location is used.

Suggested change

& ./dotnet-install.ps1 -Verbose:$Debug -DryRun:$DryRun @installParams

& "$InstallDir/dotnet-install.ps1" -Verbose:$Debug -DryRun:$DryRun @installParams

paulmedynski

Commentary for reviewers.

paulmedynski · 2025-12-05T20:45:00Z

eng/pipelines/steps/install-dotnet-arm64.ps1

Creating a separate PowerShell file for this work has several benefits:

Easy to test locally.

IDE syntax highlighting and intellisense.

Easier to review.

paulmedynski · 2025-12-05T20:46:01Z

eng/pipelines/steps/install-dotnet-arm64.ps1

+  an empty array.
+
+.NOTES
+  Licensed to the .NET Foundation under one or more agreements.


The first line in the file needs to be the comment-based help <# #>, so the license needs to go somewhere else. This was Gemini's suggestion.

- Formatting ARM64 runtimes with quotes.

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

Copilot · 2025-12-08T14:39:31Z

eng/pipelines/common/templates/steps/pre-build-step.yml

+  # Install the .NET SDK and Runtimes.
+  - template: /eng/pipelines/steps/install-dotnet.yml@self
+    parameters:
+      runtimes: ['8.0', '9.0']


Inconsistent runtime version format. Other pipeline files use ['8.x', '9.x'] format (e.g., ci-run-tests-job.yml:117, stress-tests-ci-job.yml:137), but this uses ['8.0', '9.0']. For the UseDotNet@2 task, the .x suffix is standard and allows automatic selection of the latest patch version. Consider changing to ['8.x', '9.x'] for consistency and to match the documented format for UseDotNet@2.

Suggested change

runtimes: ['8.0', '9.0']

runtimes: ['8.x', '9.x']

Copilot · 2025-12-08T14:39:32Z

eng/pipelines/steps/install-dotnet-arm64.ps1

+}
+
+#------------------------------------------------------------------------------
+# Download the dotnet-install.ps1 script it if isn't already present.


Typo: "script it if" should be "script if".

Suggested change

# Download the dotnet-install.ps1 script it if isn't already present.

# Download the dotnet-install.ps1 script if it isn't already present.

Copilot · 2025-12-08T14:39:32Z

eng/pipelines/dotnet-sqlclient-ci-core.yml

          pool: ADO-CI-PUBLIC-ARM64-1ES-EUS-POOL
          images: 
            Win11_ARM64_Azure_Sql: ADO-WIN11-ARM64
+          isArm64: true,


Invalid YAML syntax: There is a trailing comma after true which is not valid in YAML. The comma should be removed. This should be isArm64: true without the comma.

Suggested change

isArm64: true,

isArm64: true

Copilot · 2025-12-08T14:39:33Z

eng/pipelines/steps/install-dotnet.yml

+    - task: PowerShell@2
+      displayName: Install .NET SDK and Runtimes for ARM64
+      pwsh: true
+      filePath: install-dotnet-arm64.ps1


The filePath should specify a full or relative path to the PowerShell script. Currently it only specifies the filename install-dotnet-arm64.ps1, which may not be found unless it's in the working directory. Consider using a path like $(Build.SourcesDirectory)/eng/pipelines/steps/install-dotnet-arm64.ps1 or use workingDirectory parameter to set the correct directory.

Suggested change

filePath: install-dotnet-arm64.ps1

filePath: $(Build.SourcesDirectory)/eng/pipelines/steps/install-dotnet-arm64.ps1

Copilot AI review requested due to automatic review settings November 21, 2025 15:22

Copilot started reviewing on behalf of paulmedynski November 21, 2025 15:23 View session

Copilot finished reviewing on behalf of paulmedynski November 21, 2025 15:24

Copilot AI reviewed Nov 21, 2025

View reviewed changes

global.json Outdated Show resolved Hide resolved

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved

eng/pipelines/jobs/stress-tests-ci-job.yml Outdated Show resolved Hide resolved

paulmedynski commented Nov 21, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 21, 2025 17:44

Copilot started reviewing on behalf of paulmedynski November 21, 2025 17:45 View session

Copilot finished reviewing on behalf of paulmedynski November 21, 2025 17:48

Copilot AI reviewed Nov 21, 2025

View reviewed changes

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Show resolved Hide resolved

paulmedynski mentioned this pull request Nov 21, 2025

Adding support for .NET 10 #3686

Merged

Copilot AI review requested due to automatic review settings November 24, 2025 12:29

Copilot started reviewing on behalf of paulmedynski November 24, 2025 12:30 View session

Copilot finished reviewing on behalf of paulmedynski November 24, 2025 12:32

Copilot AI reviewed Nov 24, 2025

View reviewed changes

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 24, 2025 13:59

Copilot started reviewing on behalf of paulmedynski November 24, 2025 14:00 View session

Copilot finished reviewing on behalf of paulmedynski November 24, 2025 14:01

Copilot AI reviewed Nov 24, 2025

View reviewed changes

eng/pipelines/stages/stress-tests-ci-stage.yml Show resolved Hide resolved

eng/pipelines/common/templates/steps/ci-project-build-step.yml Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 24, 2025 16:17

Copilot started reviewing on behalf of paulmedynski November 24, 2025 16:18 View session

Copilot finished reviewing on behalf of paulmedynski November 24, 2025 16:21

Copilot AI reviewed Nov 24, 2025

View reviewed changes

eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 25, 2025 11:51

Copilot started reviewing on behalf of paulmedynski November 25, 2025 11:51 View session

Copilot finished reviewing on behalf of paulmedynski November 25, 2025 11:55

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 25, 2025 14:23

Copilot started reviewing on behalf of paulmedynski November 25, 2025 14:24 View session

Copilot finished reviewing on behalf of paulmedynski November 25, 2025 14:27

Copilot AI reviewed Nov 25, 2025

View reviewed changes

eng/pipelines/common/templates/steps/ensure-dotnet-version.yml Outdated Show resolved Hide resolved

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved

eng/pipelines/common/templates/steps/ensure-dotnet-version.yml Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of paulmedynski November 27, 2025 13:49 View session

Copilot finished reviewing on behalf of paulmedynski November 27, 2025 13:53

Copilot AI reviewed Nov 27, 2025

View reviewed changes

README.md Show resolved Hide resolved

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved

eng/pipelines/steps/install-dotnet-arm64.yml Outdated Show resolved Hide resolved

eng/pipelines/steps/install-dotnet-arm64.yml Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 27, 2025 17:48

Copilot started reviewing on behalf of paulmedynski November 27, 2025 17:48 View session

Copilot finished reviewing on behalf of paulmedynski November 27, 2025 17:52

Copilot AI reviewed Nov 27, 2025

View reviewed changes

priyankatiwari08 self-assigned this Nov 28, 2025

paulmedynski force-pushed the dev/paul/global-json branch from 1388f65 to bf917e9 Compare November 28, 2025 12:26

Copilot AI mentioned this pull request Dec 2, 2025

Disable scanning of Actions in CodeQL workflow #3819

Merged

Copilot AI mentioned this pull request Dec 4, 2025

[6.0] Fix xevent and codeql (#3775)(#3819), add global.json #3827

Merged

- Removing leftover .NET 9 in a few places.

7d5298e

Copilot AI review requested due to automatic review settings December 4, 2025 19:22

paulmedynski force-pushed the dev/paul/global-json branch from bf917e9 to 7d5298e Compare December 4, 2025 19:22

Copilot started reviewing on behalf of paulmedynski December 4, 2025 19:22 View session

Copilot finished reviewing on behalf of paulmedynski December 4, 2025 19:25

Copilot AI reviewed Dec 4, 2025

View reviewed changes

BUILDGUIDE.md Show resolved Hide resolved

eng/pipelines/steps/install-dotnet-arm64.yml Outdated Show resolved Hide resolved

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Outdated Show resolved Hide resolved

eng/pipelines/stages/stress-tests-ci-stage.yml Show resolved Hide resolved

paulmedynski added 2 commits December 5, 2025 08:39

- Added missing .NET 9 Runtime for the test jobs.

c83462d

- Created separate PowerShell script to install .NET for ARM64.

9834c94

- Updated install-dotnet template to handle all cases of .NET SDK and Runtime installation for the pipelines.

Copilot AI review requested due to automatic review settings December 5, 2025 20:38

Copilot started reviewing on behalf of paulmedynski December 5, 2025 20:39 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

paulmedynski commented Dec 5, 2025

View reviewed changes

paulmedynski added 2 commits December 8, 2025 09:08

- Fixed .NET Runtime versions when calling install-dotnet template.

8960c4d

- Added missing ARM64 flag to test config.

2ca062a

- Formatting ARM64 runtimes with quotes.

Copilot AI review requested due to automatic review settings December 8, 2025 14:32

Copilot started reviewing on behalf of paulmedynski December 8, 2025 14:32 View session

Copilot AI reviewed Dec 8, 2025

View reviewed changes

- Using wildcards for .NET runtimes (except ARM64).

897a15a

	..\eng\pipelines\steps\install-dotnet-arm64.yml = ..\eng\pipelines\steps\install-dotnet-arm64.yml
	..\eng\pipelines\steps\install-dotnet-arm64.ps1 = ..\eng\pipelines\steps\install-dotnet-arm64.ps1

	filePath: install-dotnet-arm64.ps1
	filePath: $(Build.SourcesDirectory)/eng/pipelines/steps/install-dotnet-arm64.ps1

	& ./dotnet-install.ps1 -Verbose:$Debug -DryRun:$DryRun @installParams
	& "$InstallDir/dotnet-install.ps1" -Verbose:$Debug -DryRun:$DryRun @installParams

	# Download the dotnet-install.ps1 script it if isn't already present.
	# Download the dotnet-install.ps1 script if it isn't already present.

[DRAFT] Use global.json to restrict .NET SDK use #3797

Are you sure you want to change the base?

[DRAFT] Use global.json to restrict .NET SDK use #3797

Uh oh!

Conversation

paulmedynski commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

paulmedynski Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paulmedynski Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

paulmedynski Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

paulmedynski commented Nov 21, 2025 •

edited

Loading