[6.1] Optimization: Use Environment.TickCount for SqlStatistics execution timing #3830
+74
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the SqlStatistics execution timing mechanism by replacing the high-precision DateTime.UtcNow timer with the more efficient Environment.TickCount for measuring execution time. This change improves performance while maintaining millisecond precision for the ExecutionTime statistic. The PR is a port of #3609 to the release/6.1 branch.
Key Changes
- Introduced
Environment.TickCount-based timing for ExecutionTime measurements with proper wraparound handling - Changed
_startExecutionTimestampfromlongtolong?to distinguish between "not started" (null) and "started" states - Removed timing relationship assertions that can no longer be guaranteed due to different timer granularities
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Common/AdapterUtil.cs |
Added FastTimerCurrent() and CalculateTickCountElapsed() helper methods for Environment.TickCount-based timing |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlStatistics.cs |
Updated ExecutionTime tracking to use Environment.TickCount, changed _startExecutionTimestamp to nullable long, and removed TimerToMilliseconds conversion for ExecutionTime |
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/TickCountElapsedTest.cs |
Added comprehensive unit tests for wraparound scenarios in TickCount elapsed time calculations |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlBulkCopyTest/CopyAllFromReader.cs |
Removed timing relationship assertions that cannot be guaranteed with mixed timer types |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlStatistics.cs
Show resolved
Hide resolved
paulmedynski
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #3609 to release/6.1
Closes #3762