Adding "Starting with .NET 10.2" to the newly added unit in metric generator #50379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariamgerges
requested review from
IEvangelist
and removed request for
Copilot and
tommcdon
IEvangelist
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds version qualifiers to indicate when the Unit parameter feature becomes available for metrics generation in .NET. The changes prepend "Starting with .NET 10.2," to existing documentation in two files that describe the metrics unit specification feature.
Key Changes
- Added version availability information for the
Unitparameter in metrics generation - Changes applied consistently across both metrics documentation files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/core/diagnostics/metrics-generator.md | Added "Starting with .NET 10.2," qualifier to the unit specification section |
| docs/core/diagnostics/metrics-strongly-typed.md | Added "Starting with .NET 10.2," qualifier to the unit specification section for strongly-typed metrics |
IEvangelist
approved these changes
Dec 8, 2025
mariamgerges
changed the title
Member
|
This might be as simple as a rebuild to fix the warnings. I think we updated the System.CommandLine APIs this morning in a different PR. Trying it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)
Internal previews