Skip to content

Conversation

@Toshimonster
Copy link

Fix transparency and text. The same fix can be done with the appmenu aswell. Perhaps this is a difference with rofi?

Fix transparency and text
@ildar
Copy link

ildar commented Sep 3, 2021 via email

@Toshimonster
Copy link
Author

Sorry, I don't fully understand the reasoning. First off, do you have picom working? it makes Rofi semi-transparent. Also visual changes are good to be illustrated by (small) screenshot(s).

ah, fair enough - sorry, made this PR quickly at the end of the day!
Images are with the raw configuration files from the repo 'Floppy'
image
image

Also, after looking at this, it seems I have failed to configure the search bar. will have an actual look today, rather than a quick 5 min job ^^

(=> tested on rofi-git and rofi, as I would assume this is a rofi ordeal rather than anything on the compositor side.)

@Toshimonster
Copy link
Author

Finally, the full screen tag should be defined under the window object, not the configuration object

@ghost
Copy link

ghost commented Sep 5, 2021

Hello, this happened to me once i updated/upgraded my system. I am using a custom linear theme.
2021-09-05_19-22

Edit: I added the lines Toshimonster@fc10acd, and it's now transparent, but found a problem with rofi scaling(not full screen), and icon placement(not centered)

2021-09-05_19-52

fix for full screen:

window {
	transparency: "real";
	background-color: @transparent;
	text-color: @foreground;
	fullscreen: true;
}

fix for icon placement:

element-icon {
	horizontal-align: 0.5;
	vertical-align: 0.5;
	background-color: @transparent;
	size: 72px;
}

@ildar
Copy link

ildar commented Sep 7, 2021 via email

@ghost
Copy link

ghost commented Sep 7, 2021

ugly indeed. I suggest this is due to the outdated rofi. I have 1.6.1 showing smooth picture: https://raw.githubusercontent.com/manilarome/the-glorious-screenshots/master/app-menu.webp

Yes, I think this is due because we updated/upgraded our system. I am running version 1.7.0 now, on my system.

@ildar
Copy link

ildar commented Sep 7, 2021 via email

Copy link

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue I had with theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants