Skip to content

fix: make sure that the server returns a non zero revised session timeout #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
istyf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make sure that the server returns a non zero revised session timeout #840

istyf wants to merge 1 commit into from

Conversation

@istyf
Copy link

@istyf istyf commented Dec 3, 2025 

The session service created allowed range and default in milliseconds, but compared
and divided with a time.Duration that is expressed in nanoseconds. The result was that 
the returned revised timeout was always zero.

Problem happened here: https://github.com/gopcua/opcua/blob/0d83d1cc736a5db59bfbb31a167d3e9c6b09c845/server/session_service.go#L76

This is a potential fix for #830 that talks about a connection failure due to a bad timeout value.

@istyf
fix to make sure that the server returns a non zero revised session t…
83d4475 
…imeout

    The session service created allowed range and default in millisecond, but compared
    with a time.Duration that is expressed in nanoseconds. The result was that the
    returned revised timeout was always zero.
@istyf istyf mentioned this pull request Dec 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@istyf