Fix for a build error on modern MSVC #2520
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Now I wonder. This PR has not been merged yet but when I opened #2521 the Windows build completed successfully. Could it be that this PR is no longer necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Fix for a build error on modern MSVC
assignees: ''
Description:
GitHub is having issues with building DPG for Windows. In particular, the compiler can't resolve an ambiguous
abs()call where the argument isfloat(andabsis an integer function). While we could simply changestarttofloat, I preferred to keep the current logic because I'm going to add another PR in future that will fix more issues in the loading indicator, so no need to change the behavior now. I'm only helping the compiler choose the rightabsoverload :).Concerning Areas:
None.