Skip to content

fix: add nodeSelector on Linux to avoid crash on Windows node #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyzhangx wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix: add nodeSelector on Linux to avoid crash on Windows node #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/lws/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ resources:
# requests:
# cpu: 100m
# memory: 128Mi
nodeSelector: {}
nodeSelector:
Copy link
Contributor

@ardaguclu ardaguclu Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does kustomize include this selector?

Copy link
Member Author

@andyzhangx andyzhangx Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have searched in this repo, it does not contain kubernetes.io/os: linux nodeSelector, I think we should use this nodeSelector value by default, and user could specify other values if necessary.

Copy link
Contributor

@ahg-g ahg-g Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use tolerations (we already have that below), basically setting that by default this doesn't tolerate running on windows machines.

kubernetes.io/os: linux
tolerations: []
affinity: {}
# gangSchedulingManagement is configuration for gang scheduling management.
Expand Down