-
Notifications
You must be signed in to change notification settings - Fork 1.4k
perf(kanvas): lazy-load non-critical sections and reduce unused JavaS… #7146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🚀 Preview for commit 96d1cc0 at: https://6922e1d23100b6619275b4a6--layer5.netlify.app |
|
@Azizah2023 Please remove all unnecessary lint changes such as extra lines and spaces, and keep only the original logic. |
|
🚀 Preview for commit dbaf1ba at: https://6922f3322f7dd379d9da1bc4--layer5.netlify.app |
|
🚀 Preview for commit c0877e6 at: https://692591ed3e676a76d57e9e24--layer5.netlify.app |
|
Checks are currently failing, possibly due to the latest Gatsby update |
…cript Signed-off-by: Azizah2023 <A.alshehri@thegarage.sa>
Signed-off-by: Azizah2023 <A.alshehri@thegarage.sa>
e348de9 to
014680e
Compare
Signed-off-by: Azizah <121037475+Azizah2023@users.noreply.github.com>
|
@Azizah2023 |
Signed-off-by: Azizah2023 <A.alshehri@thegarage.sa>
Signed-off-by: Azizah <121037475+Azizah2023@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Azizah2023
Please ensure that your commit messages are meaningful rather than repeating the same message, as we need a clear history of changes. Finally, I noticed some files only contain formatting updates (like spacing). Please revert those specific modifications so we can keep the pull request focused strictly on functional code changes.
|
@Azizah2023 Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
@Azizah2023 Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would 🙂 |
7a93a83 to
a5ed310
Compare
|
🚀 Preview for commit a5ed310 at: https://6936a373e62416d0c58ccb6b--layer5.netlify.app |
|
🚀 Preview for commit 0e6d3de at: https://6936a9d70775ef02ce4727d2--layer5.netlify.app |
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
1 similar comment
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
Signed-off-by: Azizah2023 <A.alshehri@thegarage.sa>
0e6d3de to
8d2e5ee
Compare
|
🚀 Preview for commit 8d2e5ee at: https://6936d8527994ab06e3a9817b--layer5.netlify.app |
|
🚀 Preview for commit 93b6fde at: https://6937065250b01e7f4f98ee18--layer5.netlify.app |
Description
Changes
import()+useEffect.Notes
fix/seo-alt-links-kanvas, which became noisy after syncing with master.This PR fixes #
#7110
Notes for Reviewers
Signed commits