Skip to content

Conversation

@mirco0
Copy link

@mirco0 mirco0 commented Jan 30, 2023

This pull request adds a new view waveformTimeline. This new view includes:

  • MediaPlayer
  • Timestamps
  • Audio area selector
  • Touch controls integrated with new

Todo list

  • Fix bugs relative to waveGap and waveWidth greater than minimal values

@lincollincol
Copy link
Contributor

lincollincol commented Feb 4, 2023

@mirco0 Hello! Thank you for your contribution to this project.
I have checked your code and I'm not sure about MediaPlayer instance inside view. How it will work if the user populate list (recycler view) of waveforms? 🤔

Maybe it will be better to provide an API like attach or set player. In this case, the user can provide an external player. This approach seems more flexible IMHO

@massoudss

@mirco0
Copy link
Author

mirco0 commented Feb 4, 2023

@massoudss Hello! Thank you for telling me about the issue in my code. I think your solution is a good idea, I'll update and fix my code when possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants