UrlEncode the convId for ReplyToActivity and SendToConversation #532
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds URL encoding to conversation IDs and activity IDs in the ReplyToActivity and SendToConversation REST API methods to handle special characters in these identifiers. The change also refactors the conversation ID truncation logic into a reusable helper method.
- Adds
HttpUtility.UrlEncode()to conversation and activity IDs in URL paths for two key methods - Refactors conversation ID truncation logic from inline code into a dedicated
TruncateConversationId()helper method - Reorganizes using statements to include
System.Webnamespace
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/libraries/Client/Microsoft.Agents.Connector/RestClients/ConversationsRestClient.cs
Show resolved
Hide resolved
src/libraries/Client/Microsoft.Agents.Connector/RestClients/ConversationsRestClient.cs
Show resolved
Hide resolved
src/libraries/Client/Microsoft.Agents.Connector/RestClients/ConversationsRestClient.cs
Show resolved
Hide resolved
src/libraries/Client/Microsoft.Agents.Connector/RestClients/ConversationsRestClient.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531