-
-
Notifications
You must be signed in to change notification settings - Fork 77
Open
Labels
0. Needs triagePending approval or rejection. This issue is pending approval.Pending approval or rejection. This issue is pending approval.bugSomething isn't workingSomething isn't working
Description
Describe the bug
"Create new album from filters" adds images from the whole of Nextcloud, not just the media folders
To Reproduce
Steps to reproduce the behaviour:
- Create a "Photos" folder in the Nextcloud root.
- In Photos, add the Photos folder as a media folder and an upload folder.
- Add some photos with EXIF data in a specified date range to the Photos folder.
- Add a different photo with EXIF data in that range to the root folder.
- Update thumbnails.
- In Photos, click on Photos.
- The photos in the Photos folder should be seen, and the photo in the root folder should not.
- Set a filter for a date range that encompasses all the photos.
- Click "Create new album from filters" and name the album.
- Go to the album.
Expected behaviour
The album should not contain the image that was in the root folder — but it does!
Desktop (please complete the following information):
- OS: macOS 15.7.1 (24G231)
- Browser Vivaldi
- Version 6.8.3381.48 (Stable channel) (arm64)
Smartphone (please complete the following information):
Not used on smartphone.
Browser log
[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
re @ chunk-UVKO6OCU.js:6
m @ menu.js:101
ge @ chunk-UVKO6OCU.js:6
m @ menu.js:101
ge @ chunk-UVKO6OCU.js:6
m @ menu.js:101
p @ menu.js:101
pe @ chunk-UVKO6OCU.js:6
Y @ chunk-UVKO6OCU.js:6
collectionFetcher.ts:91 [DEBUG] photos: [Collections] Fetched a collection: {app: 'photos', uid: 'user', level: 0, data: {…}}
collectionFetcher.ts:190 [DEBUG] photos: [Collections] Fetched 82 new files: {app: 'photos', uid: 'user', level: 0, fetchedFiles: Array(82)}
TiledLayout.vue:57 [DEBUG] photos: [TiledLayout] Computing rows {app: 'photos', uid: 'user', level: 0, items: Array(1)}
VirtualScrolling.vue:101 [DEBUG] photos: [VirtualScrolling] Computing visible section {app: 'photos', uid: 'user', level: 0, sections: Array(1)}
VirtualScrolling.vue:232 [DEBUG] photos: [VirtualScrolling] Computing container {app: 'photos', uid: 'user', level: 0}
TiledLayout.vue:57 [DEBUG] photos: [TiledLayout] Computing rows {app: 'photos', uid: 'user', level: 0, items: Array(1)}
VirtualScrolling.vue:101 [DEBUG] photos: [VirtualScrolling] Computing visible section {app: 'photos', uid: 'user', level: 0, sections: Array(1)}
VirtualScrolling.vue:245 [DEBUG] photos: [VirtualScrolling] isNearBottom changed {app: 'photos', uid: 'user', level: 0, value: true}
VirtualScrolling.vue:101 [DEBUG] photos: [VirtualScrolling] Computing visible section {app: 'photos', uid: 'user', level: 0, sections: Array(1)}
TiledLayout.vue:57 [DEBUG] photos: [TiledLayout] Computing rows {app: 'photos', uid: 'user', level: 0, items: Array(1)}
VirtualScrolling.vue:245 [DEBUG] photos: [VirtualScrolling] isNearBottom changed {app: 'photos', uid: 'user', level: 0, value: false}
VirtualScrolling.vue:101 [DEBUG] photos: [VirtualScrolling] Computing visible section {app: 'photos', uid: 'user', level: 0, sections: Array(1)}
TiledLayout.vue:57 [DEBUG] photos: [TiledLayout] Computing rows {app: 'photos', uid: 'user', level: 0, items: Array(1)}
VirtualScrolling.vue:101 [DEBUG] photos: [VirtualScrolling] Computing visible section {app: 'photos', uid: 'user', level: 0, sections: Array(1)}
index.js:293 OC.requestToken
Additional context
This is particularly problematic as the offending photos cannot be removed from the album — trying to delete any photo (whether it's in Photos or the root folder) gives "Error: Root must be part of the source". That's an error message that could do with being rewritten so people can understand what it means, too 😁
Metadata
Metadata
Assignees
Labels
0. Needs triagePending approval or rejection. This issue is pending approval.Pending approval or rejection. This issue is pending approval.bugSomething isn't workingSomething isn't working
