Duplicate snapshot name in a parallel build causes missing snapshots

[esetnik]

percy-cypress/index.js

Line 75 in 9e41a39

log.error(error);

The catch block should rethrow the error to fail the test if there is an error generating the snapshot.

[github-actions[bot]]

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[esetnik]

@Robdel12 please mark as not stale

[github-actions[bot]]

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[esetnik]

@Robdel12 please mark as not stale

[itsjwala]

Hey @esetnik 👋

we'll look into this issue.

++ @samarsault

[samarsault]

@esetnik Can you share the build url and a reproducible example for this?

[esetnik]

I cannot share a private project. Here's a build url for you.

https://percy.io/283b5e1b/ProdigyEMS/builds/23569245/unchanged/1317616280?browser=firefox&viewLayout=side-by-side&viewMode=new&width=1280

[github-actions[bot]]

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[itsjwala]

Hi @esetnik 👋

The modified cypress SDK can be installed from this git repo by using this command:
npm i --save-dev https://github.com/BrowserStackCE/percy-cypress.git

What it looks like in the package.json file:
"@percy/cypress": "github:BrowserStackCE/percy-cypress"

we'll be merging this upstream post doing some regression.

[esetnik]

@itsjwala is this project abandoned? I didn't get any review of my PR and it was closed with no comment. #569

[itsjwala]

Hi @esetnik nope, I'll reopen it. Currently we're doing regression on our side.

[esetnik]

You should disable your github-actions since the repository is not being monitored it keeps marking things as stale that have not received any attention from a percy team member.

[itsjwala]

@esetnik apologies we're improving our processes for this.

Also coming to your original issue for which this is raised. can you check if percy/cli#281 (comment) helps in resolving your issue?

[esetnik]

It does, although I'd still prefer for percy-cypress to fail with an error if a snapshot cannot be generated.

[itsjwala]

Acknowledged, currently, all our SDKs currently log errors, we'd want to make this behavior change across all our 17+ SDKs

I've already taken this request to my engineering team.

[esetnik]

@itsjwala any update on this?

[itsjwala]

• rethrowing the error back to the user has been added as an OKR item.
• Currently it's not prioritized yet, you may use ref our internal fork for this repo till then.