[INS-37] Fixed the issue of ftp connection ignoring the detector's co… #4590
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Comment on lines
+83
to
+89
| if dl, ok := ctx.Deadline(); ok { | ||
| // Here we assign the remaining time before our context expires | ||
| // This help us cater the timelimit set through --detector-timeout flag | ||
| timeout = time.Until(dl) | ||
| } else { | ||
| timeout = defaultVerificationTimeout | ||
| } |
Contributor
Contributor
|
|
kashifkhan0771
approved these changes
Dec 9, 2025
Contributor
|
@trufflesecurity/product-eng please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of Fixes
Resolved timeout issue:
The verification logic was unintentionally using the default timeout because the detector context's remaining time wasn’t being forwarded.
Updated the implementation to pass the remaining context deadline into
verifyFTP, ensuring correct timeout behavior.Fixed failing tests:
Tests began failing due to the introduction of the unexported
primarySecretfield indetectors.Result.Updated the test comparison to ignore this unexported field, restoring expected test behavior.