in personal.info.custom the `image` does not work

[CMon]

Describe the bug
I try to a add a repository where no icon exists inside font-awesome, the example toml and the code suggest that image should be used for this. but if I set it like its mentioned inside the toml file, I get an error from the toml parser:

error: failed to parse TOML (invalid string
expected `"`, `'` at line 63 column 15)
  ┌─ cv.typ:3:21
  │
3 │ #let metadata = toml("./metadata.toml")
  │                      ^^^^^^^^^^^^^^^^^

and if i only provide the string, then I get an error from the lib:

error: type string has no method `with`
   ┌─ @preview/brilliant-cv:2.0.5/cv.typ:99:21
   │
99 │           icon = img.with(width: 10pt)

To Reproduce
Steps to reproduce the behavior:

1. add a personal.info.custom-1 entry
2. try to add an image entry for that entry
3. compile

Expected behavior
Have the lib parse a path into an image instead of expecting it to be an image instance after toml parsing

[yunanwg]

Hi @CMon sorry for the delay, I was thinking of taking a look at this issue earlier but got soon distracted from work...

Thanks for spotting this, I confirm this is not working. The reason behind this is that an eval was omitted in the cv.typ when we try to load the path:

if k.contains("custom") {
        let img = v.at("image", default: "")
        let awesomeIcon = v.at("awesomeIcon", default: "")
        let text = v.at("text", default: "")
        let link_value = v.at("link", default: "")
        let icon = ""
        if img != "" {
          img = eval(img)      <---- this should have been added
          icon = img.with(width: 10pt)
        } else {
          icon = fa-icon(awesomeIcon)
        }
        box({
          icon
          h(5pt)
          link(link_value)[#text]
        })
      }

But that brings another bug, which is related to how Typst handles path, as this was already mentioned before:

Just took a look at it, it is going to be very hacky or complicated as long as Typst doesn't propose a better path handling mechanism. Also, toml file is really not handled for this kind of customized usage in Typst.

I suggest to close the issue for the time being, for the sake of keeping the template simple. Don't hesitate to fork, modify and use this template locally.

Originally posted by @yunanwg in #59

I can definitely fix the first issue by adding the right eval clause, but that wouldn't 100% fix the problem. One should still wait for Typst's upstream update in order to make this fully useable.

I will leave this issue open and also surely open for any suggestions!