Skip to content

Conversation

@hshoff
Copy link
Member

@hshoff hshoff commented May 28, 2024

🚀 Enhancements

  • feat(marker): add <MarkerCircle2>, same as <MarkerCircle> but default refX to mid point instead of zero. Adding a 2 component to fix the bug without releasing a visx@4 since it would be a breaking change to update the default refX={0} to mid in the <MarkerCircle> implementation. Some project might be depending on refX={0} to be set. Fixes MarkerCircle not working #1756

📝 Documentation

  • feat(demo): update curves sandbox to use <MarkerCircle2>. Recommend using <MarkerCircle2> over <MarkerCircle> for bug fix/centered defaults.
before after
marker-circle2-before marker-circle2-after

@williaster

@github-actions
Copy link

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
visx-marker 🔺 +17.3% 10.48 KB 8.94 KB 12.93 KB 11.08 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "visx-annotation": {
    "esm": 31002,
    "lib": 43431
  },
  "visx-axis": {
    "esm": 21783,
    "lib": 26434
  },
  "visx-bounds": {
    "esm": 2948,
    "lib": 3371
  },
  "visx-brush": {
    "esm": 56194,
    "lib": 60810
  },
  "visx-chord": {
    "esm": 3478,
    "lib": 4691
  },
  "visx-clip-path": {
    "esm": 4524,
    "lib": 6062
  },
  "visx-curve": {
    "esm": 323,
    "lib": 1462
  },
  "visx-delaunay": {
    "esm": 2599,
    "lib": 3428
  },
  "visx-demo": {
    "esm": 0,
    "lib": 36731
  },
  "visx-drag": {
    "esm": 12756,
    "lib": 14402
  },
  "visx-event": {
    "esm": 3878,
    "lib": 5194
  },
  "visx-geo": {
    "esm": 13662,
    "lib": 16903
  },
  "visx-glyph": {
    "esm": 15177,
    "lib": 19992
  },
  "visx-gradient": {
    "esm": 18202,
    "lib": 22847
  },
  "visx-grid": {
    "esm": 18982,
    "lib": 22665
  },
  "visx-group": {
    "esm": 1648,
    "lib": 2267
  },
  "visx-heatmap": {
    "esm": 7394,
    "lib": 8731
  },
  "visx-hierarchy": {
    "esm": 12093,
    "lib": 17910
  },
  "visx-legend": {
    "esm": 26975,
    "lib": 34055
  },
  "visx-marker": {
    "esm": 9152,
    "lib": 11350
  },
  "visx-mock-data": {
    "esm": 326040,
    "lib": 329480
  },
  "visx-network": {
    "esm": 4674,
    "lib": 6809
  },
  "visx-pattern": {
    "esm": 11689,
    "lib": 15763
  },
  "visx-point": {
    "esm": 1003,
    "lib": 1818
  },
  "visx-react-spring": {
    "esm": 14040,
    "lib": 17765
  },
  "visx-responsive": {
    "esm": 16350,
    "lib": 18791
  },
  "visx-scale": {
    "esm": 18870,
    "lib": 30555
  },
  "visx-shape": {
    "esm": 86912,
    "lib": 108820
  },
  "visx-stats": {
    "esm": 13738,
    "lib": 15320
  },
  "visx-text": {
    "esm": 8567,
    "lib": 10114
  },
  "visx-threshold": {
    "esm": 2907,
    "lib": 3806
  },
  "visx-tooltip": {
    "esm": 15233,
    "lib": 21734
  },
  "visx-vendor": {
    "esm": 2492,
    "lib": 2702
  },
  "visx-visx": {
    "esm": 1524,
    "lib": 4487
  },
  "visx-voronoi": {
    "esm": 2314,
    "lib": 3021
  },
  "visx-wordcloud": {
    "esm": 2620,
    "lib": 3455
  },
  "visx-xychart": {
    "esm": 178434,
    "lib": 240233
  },
  "visx-zoom": {
    "esm": 16239,
    "lib": 19297
  }
}

Current

{
  "visx-annotation": {
    "esm": 31002,
    "lib": 43431
  },
  "visx-axis": {
    "esm": 21783,
    "lib": 26434
  },
  "visx-bounds": {
    "esm": 2948,
    "lib": 3371
  },
  "visx-brush": {
    "esm": 56194,
    "lib": 60810
  },
  "visx-chord": {
    "esm": 3478,
    "lib": 4691
  },
  "visx-clip-path": {
    "esm": 4524,
    "lib": 6062
  },
  "visx-curve": {
    "esm": 323,
    "lib": 1462
  },
  "visx-delaunay": {
    "esm": 2599,
    "lib": 3428
  },
  "visx-demo": {
    "esm": 0,
    "lib": 36731
  },
  "visx-drag": {
    "esm": 12756,
    "lib": 14402
  },
  "visx-event": {
    "esm": 3878,
    "lib": 5194
  },
  "visx-geo": {
    "esm": 13662,
    "lib": 16903
  },
  "visx-glyph": {
    "esm": 15177,
    "lib": 19992
  },
  "visx-gradient": {
    "esm": 18202,
    "lib": 22847
  },
  "visx-grid": {
    "esm": 18982,
    "lib": 22665
  },
  "visx-group": {
    "esm": 1648,
    "lib": 2267
  },
  "visx-heatmap": {
    "esm": 7394,
    "lib": 8731
  },
  "visx-hierarchy": {
    "esm": 12093,
    "lib": 17910
  },
  "visx-legend": {
    "esm": 26975,
    "lib": 34055
  },
  "visx-marker": {
    "esm": 10731,
    "lib": 13241
  },
  "visx-mock-data": {
    "esm": 326040,
    "lib": 329480
  },
  "visx-network": {
    "esm": 4674,
    "lib": 6809
  },
  "visx-pattern": {
    "esm": 11689,
    "lib": 15763
  },
  "visx-point": {
    "esm": 1003,
    "lib": 1818
  },
  "visx-react-spring": {
    "esm": 14040,
    "lib": 17765
  },
  "visx-responsive": {
    "esm": 16350,
    "lib": 18791
  },
  "visx-scale": {
    "esm": 18870,
    "lib": 30555
  },
  "visx-shape": {
    "esm": 86912,
    "lib": 108820
  },
  "visx-stats": {
    "esm": 13738,
    "lib": 15320
  },
  "visx-text": {
    "esm": 8567,
    "lib": 10114
  },
  "visx-threshold": {
    "esm": 2907,
    "lib": 3806
  },
  "visx-tooltip": {
    "esm": 15233,
    "lib": 21734
  },
  "visx-vendor": {
    "esm": 2492,
    "lib": 2702
  },
  "visx-visx": {
    "esm": 1524,
    "lib": 4487
  },
  "visx-voronoi": {
    "esm": 2314,
    "lib": 3021
  },
  "visx-wordcloud": {
    "esm": 2620,
    "lib": 3455
  },
  "visx-xychart": {
    "esm": 178434,
    "lib": 240233
  },
  "visx-zoom": {
    "esm": 16239,
    "lib": 19297
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MarkerCircle not working

3 participants