Skip to content

Conversation

@DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Dec 8, 2025

Fix #281915

Copilot AI review requested due to automatic review settings December 8, 2025 20:57
@DonJayamanne DonJayamanne self-assigned this Dec 8, 2025
@DonJayamanne DonJayamanne marked this pull request as ready for review December 8, 2025 20:58
@vs-code-engineering vs-code-engineering bot added this to the December / January 2026 milestone Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #281758 by ensuring that editing sessions are properly swapped for background chat agents. The fix restructures the session commit logic to handle cases where a chat session is not actively displayed in a view widget.

Key Changes

  • Refactored session state transfer logic to execute unconditionally before widget resolution
  • Added explicit handling for background agents that don't have an associated chat view widget
  • Imported ChatAgentLocation enum to properly initialize sessions for the Chat location

Tyriar
Tyriar previously approved these changes Dec 8, 2025
@DonJayamanne DonJayamanne added the candidate Issue identified as probable candidate for fixing in the next release label Dec 8, 2025
@DonJayamanne DonJayamanne enabled auto-merge (squash) December 8, 2025 21:45
@DonJayamanne DonJayamanne merged commit a810fc4 into main Dec 8, 2025
28 checks passed
@DonJayamanne DonJayamanne deleted the don/only-eagle branch December 8, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

candidate Issue identified as probable candidate for fixing in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent sessions: background session does not indicate changes until opened

4 participants